[PATCH] D81886: [AMDGPU] Add gfx1030 target

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 09:02:35 PDT 2021


foad added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245
+
+def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">,
+  AssemblerPredicate<(all_of FeatureDsSrc2Insts)>;
----------------
The `!` is obviously wrong in this definition, but if I remove it, all the tests still pass. So does this predicate actually control anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81886/new/

https://reviews.llvm.org/D81886



More information about the llvm-commits mailing list