[PATCH] D104331: [AMDGPU] Use performOptimizedStructLayout for LDS sort

[Mahesha S via Phabricator via llvm-commits]

hsmhsm accepted this revision.
hsmhsm added a comment.
This revision is now accepted and ready to land.

LGTM apart from above minor comment.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:260
         AMDGPU::getAlign(DL, LocalVars[0]); // was sorted on alignment
 
     GlobalVariable *SGV = new GlobalVariable(
----------------
Now since we are calling performOptimizedStructLayout(), I am not sure, if the struct member with max align is guarenteed to be at offset 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104331/new/

https://reviews.llvm.org/D104331