[PATCH] D104080: [LLD][LLVM] CG Graph profile using relocations

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo marked 8 inline comments as done.
ayermolo added inline comments.


================
Comment at: llvm/lib/MC/MCELFStreamer.cpp:508
+      ".llvm.call-graph-profile", ELF::SHT_LLVM_CALL_GRAPH_PROFILE,
+      ELF::SHF_EXCLUDE, 8 /* sizeof(Elf_CGProfile_Impl<>)*/);
+  PushSection();
----------------
jhenderson wrote:
> jhenderson wrote:
> > 
> This hasn't been addressed properly: the `=` at the end of the comment in my inline edit is important, as clang-format interprets such a pattern differently (note that if you add the equals sign and then reformat, the space between the comment and 8 will disappear.
ah, sorry missed the =.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6747
+
+    auto GetIndex = [&](uint32_t Index) -> uint32_t {
+      const Elf_Rel_Impl<ELFT, true> &Rel = CGProfileRela[Index];
----------------
jhenderson wrote:
> The return type of `Rel.getSymbol(...)` is already `uint32_t`, so no need for the trailing return type to be explicitly specified.
Also modified lambda in lld driver to follow the same style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104080/new/

https://reviews.llvm.org/D104080