[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

Here are my guesses of why you couldn't reproduce the failure:

1. Your local changes are not sync with the patch presented here.
2. You didn't turn on assertion. Please open `<your build folder>/CMakeCache.txt`. If the `CMAKE_BUILD_TYPE` variable is "Debug" then you're fine, if it's something else, make sure `LLVM_ENABLE_ASSERTIONS` is ON (in case you don't know, you can directly change the variable value in that file and CMake will reconfigure on the next build).

Regarding the root cause of the crash, M68k's calling convention relies on pushing parameters to the stack, so only implementing register assignment is not enough. As I suggested before, i386's implementation of GlobalISel might be a good reference.

Last but not the least, commits got reverted all the time in LLVM so please don't mind :-) You're almost there and I definitely appreciate your contribution here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542