[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

Sushma Unnibhavi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 26 21:24:42 PDT 2021


sushmaunnibhavi added a comment.

In D104542#2842720 <https://reviews.llvm.org/D104542#2842720>, @myhsu wrote:

> Also, since M68k's calling convention uses stack to pass incoming parameters, I'm not surprised `M68kIncomingValueHandler::getStackAddress` was called by GlobalISel to generate proper MIR instructions.
> I suggest you to use i386 (a.k.a 32-bit X86) as a reference to see how thing works there and how they implement IncomingValueHandler. Since i386 is also using stack to pass incoming parameters.

I will look into this. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542



More information about the llvm-commits mailing list