[PATCH] D100149: [AMDGPU][GlobalISel] Legalize and select G_SBFX and G_UBFX

Brendon Cahoon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 26 13:44:56 PDT 2021


bcahoon added a comment.

In D100149#2816330 <https://reviews.llvm.org/D100149#2816330>, @foad wrote:

> LGTM for AMDGPU, and I guess you haven't changed the behaviour for AArch64. What about other GlobalISel targets like MIPS and X86? Will they suddenly start seeing G_SBFX/G_UBSX where they weren't expecting them? Anyway I've added a couple more globalisel reviewers.

Just to follow up on the question - Neither MIPS nor X86 have added support for G_SBFX and G_UBFX, so they shouldn't see them. The target independent parts that convert to G_SBFX/G_UBFX are guarded by isLegalOrCustom() checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100149/new/

https://reviews.llvm.org/D100149



More information about the llvm-commits mailing list