[PATCH] D104909: [llvm-objdump] Prefix memory operand addresses with '0x'

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

In D104909#2842368 <https://reviews.llvm.org/D104909#2842368>, @hvdijk wrote:

> They are closer in meaning to the addresses at the start of the line, not just instructions but data as well, than to anything else though. When we want to see what e.g. `pushq 8346(%rip)  # 203280` actually refers to, we look for the line that starts with `203280`.

Thanks. `pushq 8346(%rip)  # 203280` is the perfect example of why this patch is useful. The offset here is decimal while the calculated address is hexadecimal, but that is not obvious.

> Yes, I have actually looked things up this way, this isn't hypothetical.

Well, in that case, would you like to prepare the corresponding patch? You seem to be able to substantiate it. Note that the disassembler already prints target addresses of jump/branch instructions with the '0x' prefix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104909/new/

https://reviews.llvm.org/D104909