[PATCH] D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 26 05:07:27 PDT 2021


sgraenitz added a comment.

Thanks for fixing this. Looks good to me!

Side-note: I think lljit-with-remote-debugging.test <https://github.com/llvm/llvm-project/blob/2b9016745d091385f4b41615c171988b527b1939/llvm/test/Examples/OrcV2Examples/lljit-with-remote-debugging.test> needs no change, because `LLVM_INCLUDE_TESTS` always requires <https://github.com/llvm/llvm-project/blob/2b9016745d091385f4b41615c171988b527b1939/llvm/CMakeLists.txt#L960> `LLVM_INCLUDE_UTILS`.



================
Comment at: llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/CMakeLists.txt:12
   )

-add_llvm_example(LLJITWithRemoteDebugging
-  LLJITWithRemoteDebugging.cpp
-  RemoteJITUtils.cpp
+if ( LLVM_INCLUDE_UTILS )
+  add_llvm_example(LLJITWithRemoteDebugging
----------------
Is this a whitespace change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100081/new/

https://reviews.llvm.org/D100081



More information about the llvm-commits mailing list