[PATCH] D104631: [LoopVersioning] add function to create versioned loop with plain runtime check

Yueh-Ting Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 26 01:56:55 PDT 2021


eopXD added a comment.

Hi @fhahn ,

Aside from adding helper functions, I think removing the assertion that "ensures `RuntimeCheck` is not a `nullptr`" is necessary,
since in my use-case the loop provided to `LoopVersioning` doesn't require any `MemRuntimeCheck` and `SCEVRuntimeCheck` but wants to clone the loop and setup a branch instruction for them.
Other than that I kept the interface and logic of `versionLoop` the same.

Thank you for reviewing this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104631/new/

https://reviews.llvm.org/D104631



More information about the llvm-commits mailing list