[PATCH] D104909: [llvm-objdump] Prefix memory operand addresses with '0x'

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

In D104909#2841189 <https://reviews.llvm.org/D104909#2841189>, @hvdijk wrote:

> I like the 0x, but the addresses at the start of the lines get printed without it so it introduces an inconsistency. I personally would prefer it if either both used 0x, or both leave out 0x. Is it possible to change both or does that introduce compatibility issues?

In fact, this patch fixes some inconsistencies in printing instructions and their comments. Hexadecimal constants are already prefixed with `0x` (see, for example, `lld/test/ELF/x86-64-gotpc-relax-nopic.s`), as well as targets of branch instructions (`lld/test/ELF/symver.s`), etc.

As for addresses of the instructions, personally, I do not believe they need to be prefixed. They are printed as a sequence, so there are for sure some "letter" digits among them, and thus the actual format is easily recognized. In any case, I guess that that is something unrelated to this patch, and should be done separately, if decided.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104909/new/

https://reviews.llvm.org/D104909