[PATCH] D104953: [ObjC][ARC] Prevent moving objc_retain calls past objc_release calls that release the retained object

[Akira Hatanaka via Phabricator via llvm-commits]

ahatanak planned changes to this revision.
ahatanak added inline comments.


================
Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:1513
+    for (const Instruction *InsertPt : P.second.ReverseInsertPts)
+      ReleaseInsertPtToRCIdentityRoot[InsertPt] = Root;
+  }
----------------
This isn't quite correct as it's not impossible for two different retains with different RC identity roots to have the same insertion point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104953/new/

https://reviews.llvm.org/D104953