[PATCH] D104962: Disable ReplaceLDS pass, patch up tests to match

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 17:22:45 PDT 2021


JonChesterfield created this revision.
JonChesterfield added a reviewer: hsmhsm.
Herald added subscribers: foad, nikic, kerbowa, hiraditya, nhaehnle, jvesely, arsenm.
JonChesterfield requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Disable ReplaceLDS pass, patch up tests to match

Most tests passed with an extra argument to explicitly enable the pass.
One does not, deleted it as part of this change. I can't see why the codegen
would be different between default on and default off but switched on. It
can be retrieved from the project history.

This would be a revert, but git revert was not clean. Disabling the pass
and leaving it in tree is less likely to cause breakage elsewhere than
patching up the git revert conflicts on unfamiliar code. It'll be landed
without review, as @hsmhsm is believed unavailable at present.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104962

Files:
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-diamond-shape.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-selected_functions.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-global-scope-use.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-inline-asm-call.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-kernel-only-used-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-not-reachable-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-small-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-diamond-shape.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-selected_functions.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-signature-match.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-lds-offsets.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-multiple-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-same-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr1.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr2.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-phi-inst.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104962.354634.patch
Type: text/x-patch
Size: 21638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210626/25e03e5c/attachment.bin>


More information about the llvm-commits mailing list