[PATCH] D104958: [Test] rewrite inline_nossp.ll

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 16:42:15 PDT 2021


nickdesaulniers created this revision.
nickdesaulniers added reviewers: MaskRay, pcc, rnk.
nickdesaulniers requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

While adding remark based tests in D104944 <https://reviews.llvm.org/D104944>, I noticed that the tests
that we passing were passing for the wrong reason. They were passing
because the dynamic allocas were preventing inlining, not the code I
added in D91816 <https://reviews.llvm.org/D91816>.

Rewrite and simplify the test. Add remark based checks to validate we're
preventing inline substitutions for the right reasons.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104958

Files:
  llvm/test/Transforms/Inline/inline_nossp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104958.354626.patch
Type: text/x-patch
Size: 5147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210625/d5bc8d4f/attachment.bin>


More information about the llvm-commits mailing list