[PATCH] D104950: [OpaquePtr] Support forward references in textual IR

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1152-1153
-
-    // Move the forward-reference to the correct spot in the module.
-    M->getGlobalList().splice(M->global_end(), M->getGlobalList(), GV);
-  }
----------------
dexonsmith wrote:
> Seems like we could probably keep this behaviour somehow -- getting the global to the "correct" spot in the module might avoid some of the testcase churn as well. See the example I call out below.
Ah, except, I see, reading more carefully: the newly created global variable is already in the "correct" spot. In which case the churn is likely caused by the use-list order difference...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104950/new/

https://reviews.llvm.org/D104950