[PATCH] D104950: [OpaquePtr] Support forward references in textual IR

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 15:56:49 PDT 2021


dexonsmith added a comment.

In D104950#2841883 <https://reviews.llvm.org/D104950#2841883>, @nikic wrote:

> llvm/test/Assembler/metadata-use-uselistorder.ll is failing on Windows, but not locally :(

Likely indicates non-determinism in the use-list order, which seems worth fixing (or non-determinism in the prediction; that surface area is much smaller, but maybe not well-enough tested). I'm staring at your change trying to figure out what that could be and I'm not seeing anything though...

> Out of curiosity, I ran `find . -name '*.ll' -exec echo '{}' \; -exec build/bin/verify-uselistorder {} \; >out 2>&1` without this patch, and hit quite a few failures :/

IIRC, that passed when verify-uselistorder originally landed... a shame it's getting in the way so much for the opaque pointer stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104950/new/

https://reviews.llvm.org/D104950



More information about the llvm-commits mailing list