[PATCH] D104889: [llvm-strings] Switch command line parsing from llvm::cl to OptTable

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 13:38:28 PDT 2021


MaskRay added a comment.

In D104889#2840283 <https://reviews.llvm.org/D104889#2840283>, @jhenderson wrote:

> Oh, I think this also loses the --color option, which turns off the error message colouring, if I'm not mistaken. I'm not sure either way how important this is, but thought I'd best flag it up.

`--color` is provided by a `Support/WithColor.cpp` cl::opt which doesn't do anything in llvm-strings.
I guess it cannot be discarded by linker GC due to some references from Support/ .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104889/new/

https://reviews.llvm.org/D104889



More information about the llvm-commits mailing list