[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D104714#2841457 <https://reviews.llvm.org/D104714#2841457>, @thakis wrote:

> Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/
>
>   # command stderr:
>   /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-globals.test:83:10: error: LIT-RUN: expected string not found in input
>   LIT-RUN: PASS: {{.*}} norm.c
>   
>   Input was:
>   <<<<<<
>               1: lit.py: /var/lib/buildkite-agent/builds/llvm-project/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang 
>               2: -- Testing: 2 tests, 1 workers -- 
>               3: PASS: update_cc_test_checks.py example :: norm.c (1 of 2) 
>               4: PASS: update_cc_test_checks.py example :: igf.c (2 of 2) 
>
> Looks like the test expects order igf.c, norm.c while the output is the other way round. Should this just use `LIT-RUN-DAG` so that the order doesn't matter, or should we add a `sorted()` somewhere that the output is deterministic?

I pushed cc60fa2685bd <https://reviews.llvm.org/rGcc60fa2685bdbff889df826a1bfd5e52ffd163c8> to fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104714/new/

https://reviews.llvm.org/D104714