[PATCH] D104936: [flang] Implement semantic check for the UNPACK intrinsic

[Peter Klausler via Phabricator via llvm-commits]

klausler added a comment.

Why isn't the conformance checking that's implied by the definition of UNPACK in the intrinsics table catching this case?  Is it because it only checks rank?  If so, you should put this extra compile-time checking into the general argument conformance checking, and it'll apply to more intrinsics than just UNPACK.



================
Comment at: flang/lib/Evaluate/intrinsics.cpp:2150
+                CheckConformanceFlags::LeftScalarExpandable, "FIELD= argument",
+                "MASK= arguement")
+                .value_or(false /*fail if not known now to conform*/);
----------------
spelling


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104936/new/

https://reviews.llvm.org/D104936