[PATCH] D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 25 11:31:24 PDT 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Oh, I didn't realize this breaks `-order_file` for strings. But I think it's fine to leave this for a follow-up. `--deduplicate-strings` already has that bug after all, and not creating crashing binaries is definitely better than not being able to reorder strings :)

lg. Let's wait a few hours to see if anyone else chimes in. If not, I'll land this for you.

(I kind of wish we could put make InputSection small and fast enough that we could just do one regular InputSection per string....)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104919/new/

https://reviews.llvm.org/D104919



More information about the llvm-commits mailing list