[PATCH] D104902: [OpaquePtr] Allow globals with opaque pointer value type
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 25 11:12:45 PDT 2021
dexonsmith added a comment.
> Do this by making opaque pointers a valid pointer element type, for which we implicitly create an opaque pointer (moving the logic from getPointerTo into PointerType::get).
Is there a way to test this? Maybe with something like this?
@g = global ptr null
In D104902#2840987 <https://reviews.llvm.org/D104902#2840987>, @aeubanks wrote:
> lgtm, though invalid-opaque-ptr.ll is failing and should probably be deleted
I don't understand why the testcase was deleted. It seems to indicate a hole in the verifier. Isn't this still invalid IR?
define void @f(ptr %a) {
%b = bitcast ptr %a to ptr*
ret void
}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104902/new/
https://reviews.llvm.org/D104902
More information about the llvm-commits
mailing list