[PATCH] D104795: [IVDescriptors] Make pointer inductions compatible with opaque pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:985
 
+  assert((IK != IK_PtrInduction || ElementType) &&
+         "Element type should be specified for pointer induction");
----------------
aeubanks wrote:
> should this be `(IK == IK_PtrInduction) == (ElementType != nullptr)`?
I feel like that's a bit hard to understand. What do you think about the new version that spells out the two possibilities explicitly?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104795/new/

https://reviews.llvm.org/D104795