[PATCH] D104745: [llvm-cov] Enforce alignment of function records

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp:1017
+  } else {
+    const Align RecordAlignment(8);
+    uint64_t FuncRecordsSize = 0;
----------------
worth a comment that this block computes the size taking into account of padding.


================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp:1035
         return CoverageRecordsOrErr.takeError();
-      FuncRecords += CoverageRecordsOrErr.get();
-      while (FuncRecords.size() % 8 != 0)
-        FuncRecords += '\0';
+      const auto &CoverageRecords = CoverageRecordsOrErr.get();
+      FuncRecordsBuffer = std::copy(CoverageRecords.begin(),
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104745/new/

https://reviews.llvm.org/D104745