[PATCH] D104671: [lld-macho] Extend ICF to literal sections

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 18:24:20 PDT 2021


int3 added inline comments.


================
Comment at: lld/test/MachO/icf-literals.s:32-35
+_bar1:
+  .asciz "foo"
+_bar2:
+  .asciz "foo"
----------------
gkm wrote:
> 
oops. I guess I should add a section of `callq`s like the `icf.s` test to check that we aren't deduplicating things unexpectedly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104671/new/

https://reviews.llvm.org/D104671



More information about the llvm-commits mailing list