[PATCH] D104795: [IVDescriptors] Make pointer inductions compatible with opaque pointers

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

I'm not familiar with this code, but looks fine overall with one nit



================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:985
 
+  assert((IK != IK_PtrInduction || ElementType) &&
+         "Element type should be specified for pointer induction");
----------------
should this be `(IK == IK_PtrInduction) == (ElementType != nullptr)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104795/new/

https://reviews.llvm.org/D104795