[PATCH] D104868: [ARM] Fix crash in chained BFI combine due to incorrectly RAUW'ing a node.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 12:18:06 PDT 2021


efriedma added a comment.

Change makes sense.



================
Comment at: llvm/test/CodeGen/ARM/bfi-chain-cse-crash.ll:38
+  store i8 %18, i8* %0, align 1
+  br i1 undef, label %.preheader, label %.loopexit
+
----------------
Can you simplify the testcase so it doesn't have any references to "undef"?  That tends to make testcases a lot more fragile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104868/new/

https://reviews.llvm.org/D104868



More information about the llvm-commits mailing list