[PATCH] D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 12:13:16 PDT 2021


scott.linder added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:752
+    // Parse uniqued MDNodes inline as a special case.
+#define HANDLE_MDNODE_LEAF_UNIQUED(CLASS)                                      \
+  if (Lex.getKind() == lltok::MetadataVar && Lex.getStrVal() == #CLASS) {      \
----------------
t-tye wrote:
> So are all UNIQUED nodes are now allowed to be inline?
Yes, that is the intent. In addition, all UNIQUED nodes are canonically printed inline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104827/new/

https://reviews.llvm.org/D104827



More information about the llvm-commits mailing list