[PATCH] D104860: [ARM] Fold extract of ARM_BUILD_VECTOR
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 24 10:26:25 PDT 2021
efriedma added a comment.
> For some reason, the ARM backend thinks it needs it's own BUILDVECTOR
I think the issue here is that ISD::BUILD_VECTOR has funny interactions with legalization, so you can't just mark it "Legal". So we transform to ARMISD::BUILD_VECTOR to indicate "yes, this is actually a legal operation".
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14593
+ isa<ConstantSDNode>(N->getOperand(1))) {
+ return Op0.getOperand(N->getConstantOperandVal(1));
+ }
----------------
Missing check that the constant is in range.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104860/new/
https://reviews.llvm.org/D104860
More information about the llvm-commits
mailing list