[PATCH] D104854: Introduce intrinsic llvm.isnan

Thu Jun 24 08:25:19 PDT 2021

sepavloff added a comment.

In D104854#2838659 <https://reviews.llvm.org/D104854#2838659>, @jdoerfert wrote:

> In D104854#2838495 <https://reviews.llvm.org/D104854#2838495>, @sepavloff wrote:
>
>> In D104854#2838468 <https://reviews.llvm.org/D104854#2838468>, @thopre wrote:
>>
>>> Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)?
>>
>> Yes, they have similar problems. 
>> If someone would like to implement them it would be nice.
>
> From a user perspective, it seems sub-optimal to postpone the others "untile someone wants to implement them".
> Once `isnan` behaves differently than the rest, I can see users being confused and rightfully so.
> I don't have a strong opinion but I'd prefer we switch them over together.

Sure. I Just want to say that if someone wants or has plans to implement these functions, I appreciate these efforts. This functionality is in my plans. Considering only one function in this patch must facilitatу the review process.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104854/new/

https://reviews.llvm.org/D104854