[PATCH] D104533: [LoopVectorize] Fix strict reductions where VF = 1

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9386
             RecipeBuilder.getRecipe(cast<Instruction>(R->getOperand(0)));
         assert(isa<VPWidenRecipe>(CompareRecipe) &&
                "Expected to replace a VPWidenSC");
----------------
kmclaughlin wrote:
> sdesmalen wrote:
> > Should these asserts be guarded as well?
> These asserts are only for only for min/max recurrences, so we should never reach these for ordered reductions.
I think this should be fine. If we ever do add support for in-order min/max reductions then this assert (and the other one above - `isa<VPWidenRecipe>(WidenRecipe)`) will fire and we can fix it up then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104533/new/

https://reviews.llvm.org/D104533