[PATCH] D103755: [DAG] Fold neg(bvsplat(neg(x)) -> bvsplat(x)

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 04:43:41 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3312
+
+    // Fold neg(bvsplat(neg(x)) -> bvsplat(x)
+    if (VT.isVector()) {
----------------
nit: s/bvsplat/splat/g


================
Comment at: llvm/test/CodeGen/AArch64/neon-shift-neg.ll:567
 
 define <vscale x 16 x i8> @subsub(<vscale x 16 x i8> %a, i8 %b) {
 ; CHECK-LABEL: subsub:
----------------
It seems odd to have a  scalable-vector test in `neon-shift-neg.ll` ? (I actually can't find this test in latest HEAD, am I looking at the right diff?) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103755/new/

https://reviews.llvm.org/D103755



More information about the llvm-commits mailing list