[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Thu Jun 24 04:03:20 PDT 2021

foad added inline comments.

================
Comment at: llvm/test/tools/llvm-mca/AMDGPU/gfx10-double.s:44
 # CHECK-NEXT: Instructions:      28
-# CHECK-NEXT: Total Cycles:      224
+# CHECK-NEXT: Total Cycles:      205
 # CHECK-NEXT: Total uOps:        29
----------------
andreadb wrote:
> foad wrote:
> > I'm surprised that there are no related changes to the tables below. Is this a case where the timeline view would have changed, except that it gets truncated due to some archaic notion of screen width? :-)
> You can pass flag `timeline-max-cycles` if you need to show more columns in the timeline view.
> 
> ```
> -timeline-max-cycles=<cycles>
> ```
> 
Thanks. It would be nice if there was some way of setting this limit to infinity. I've tried implementing that in D104846.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730