[PATCH] D104363: [llvm] Mark more internal command line optins as cl::Hidden

Thu Jun 24 02:03:22 PDT 2021

jhenderson added a comment.

In D104363#2838012 <https://reviews.llvm.org/D104363#2838012>, @tbaeder wrote:

> Yes, it also hides the `--color` option. I guess I need to include `&llvm::ColorCategory` everywhere.
>
> But this all seems like a lot of work in all the tools (not to mention external ones linking against `libLLVM.so` I guess?) for something that should just work. Why not mark all the llvm internal options as `cl::Hidden` instead? That way thy would also still be available via `--help-hidden`.

I don't think that's particularly useful, and at the very least needs discussing on the mailing lists. LLVM developers may well want to know about some of these options when using tools like `opt` and `llc`, and hiding them means newer LLVM develpers may never find them.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104363/new/

https://reviews.llvm.org/D104363