[PATCH] D104597: [SimplifyCFG] Tail-merging all blocks with `ret` terminator

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 01:42:49 PDT 2021


fhahn added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/swifterror.ll:429
 ; CHECK-APPLE-NEXT:    bl _malloc
-; CHECK-APPLE-NEXT:    mov w8, #1
-; CHECK-APPLE-NEXT:    fmov s0, #1.00000000
-; CHECK-APPLE-NEXT:    strb w8, [x0, #8]
 ; CHECK-APPLE-NEXT:    mov x21, x0
+; CHECK-APPLE-NEXT:    mov w8, #1
----------------
fhahn wrote:
> I noticed you auto-generated the tests for this file and the GlobalISel version. It looks like those tests intentionally only checked the relevant parts related to swifterror, but now the checks are much more verbose (and much more prone to needing updating, because they check lots of 'uninteresting things).
> 
> Given that only a few lines out of ~2000 needed updating, I am wondering if it would be better to keep the hand-written checks and just update the failing line? Going forward, I think the auto-generated ones will need updating much more frequently now. Granted it is easy to update them, but it still creates noise in diffs and in theory would require careful checking.
(The original checks also had comments interleaved to explain what is being checked. It looks like they are now all before the auto-generated check lines)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104597/new/

https://reviews.llvm.org/D104597



More information about the llvm-commits mailing list