[PATCH] D103694: [AMDGPU] Simplify handleAddressTakenFunctions. NFC.

Madhur Amilkanthwar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 00:21:56 PDT 2021


madhur13490 added a comment.

Please remove NFC due to the new context. @JonChesterfield found an issue with recursions in the base patch. The following case depicts the scenario

  target triple = "amdgcn-amd-amdhsa"
    
  define i64 @f(i64 %x)  {
  entry:
          br i1 undef, label %return, label %if.end
  
          if.end:
          %call = call i64 @f(i64 undef)
          unreachable
  
          return:
          ret i64 1
  }
  
  define i8* @unrelated() {
  entry:
   ret i8* bitcast (i64 (i64)* @f to i8*)
  }
  
  declare amdgpu_kernel void @has_a_kernel(i32)

Please add this test as a part of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103694/new/

https://reviews.llvm.org/D103694



More information about the llvm-commits mailing list