[PATCH] D104806: [ScalarEvolution] Make getMinusSCEV() fail for unrelated pointers.

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 21:39:28 PDT 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:4096
+  if (RHS->getType()->isPointerTy()) {
+    if (!LHS->getType()->isPointerTy() ||
+        getPointerBase(LHS) != getPointerBase(RHS))
----------------
Should we fail by assertion if RHS is a pointer and LHS is not? I cannot figure a physical meaning of such situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104806/new/

https://reviews.llvm.org/D104806



More information about the llvm-commits mailing list