[PATCH] D103593: [Coroutine] Sink lifetime markers after switch of suspend blocks to avoid disturbing must tail calls

Wed Jun 23 20:29:19 PDT 2021

ChuanqiXu added a comment.

In D103593#2837450 <https://reviews.llvm.org/D103593#2837450>, @lxfind wrote:

> I guess I am fine with solution 1 and see how far we can go with it. 
> In the long run, we should look at cases where this optimization (sinkLifetimeStartMarkers) is effective and figure out why the lifetime start markers are emitted early, so that we could improve the lifetime marker creation in the first place. Overall it still feels a bit strange to move lifetime markers around (a sign that the front-end didn't do the right thing)

All Agreed. Improving the accuracy for lifetime markers is a goal for me too. As I mentioned in bug 50372 <https://bugs.llvm.org/show_bug.cgi?id=50372>, I think we can do better to reduce the frame size.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103593/new/

https://reviews.llvm.org/D103593