[PATCH] D104762: [PowerPC] Move PPCBranchSelector as close to asm printer as possible

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 19:03:58 PDT 2021


nemanjai added a comment.

This is presumably something that diverged from the original position for this pass. Please add a LIT test that will check the result of `-debug-pass` so we ensure that if anything gets added between the branch selector and the asm printer, it will cause a failure. Then we can evaluate on a case-by-case basis whether the pass may change the size/order of instructions/blocks and thereby whether it needs to be inserted elsewhere in the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104762/new/

https://reviews.llvm.org/D104762



More information about the llvm-commits mailing list