[PATCH] D104734: [llvm-diff] Explicitly check ConstantStructs for differences
John McCall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 23 16:18:20 PDT 2021
rjmccall added inline comments.
================
Comment at: llvm/tools/llvm-diff/DifferenceEngine.cpp:582
+ FunctionDifferenceEngine(DifferenceEngine &Engine, const Value *SavedLHS,
+ const Value *SavedRHS)
+ : Engine(Engine), SavedLHS(SavedLHS), SavedRHS(SavedRHS),
----------------
The other constructors doesn't initialize these. Might be best to just `= nullptr` them and then override them, either here or separately after construction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104734/new/
https://reviews.llvm.org/D104734
More information about the llvm-commits
mailing list