[PATCH] D104080: [LLD][LLVM] CG Graph profile using relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> For example, if we run strip -s on the object files the symbol table changes, but indices in that section do not.

The description needs to mention what would happen with the old format.

> We propose to change this section to use relocations. The Frequency will still be in the .llvm.call-graph-profile, but symbol information will be in relocation section. In LLD information from both sections is used to reconstruct call graph profile. Relocations themselves will never be applied.

We propose => This patch changes the format by using `R_*_NONE` relocations to indicate the from/to symbols.

> With this approach post processing tools that handle relocations correctly work for this section also.

I think you might want to say adding/removing symbols?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104080/new/

https://reviews.llvm.org/D104080