[PATCH] D104597: [SimplifyCFG] Tail-merging all blocks with `ret` terminator

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Some of the test changes here look really ropy, but the performance benchmarks I tested was entirely flat, and codesize neither improved nor regressed by any significant amount.

There are some tests in here, notably the ifcvt ones, that no longer seem to be testing what they were originally intending to test.



================
Comment at: llvm/test/CodeGen/AArch64/arm64-instruction-mix-remarks.ll:42
-; CHECK-NEXT:    mul w8, w8, w1
-; CHECK-NEXT:    str w9, [x0]
-; CHECK-NEXT:    mov w0, w8
----------------
I don't know this test, but what happened to this store?


================
Comment at: llvm/test/CodeGen/ARM/smml.ll:67
 ;
+; CHECK-THUMBV7-LABEL: Test0:
+; CHECK-THUMBV7:       @ %bb.0: @ %entry
----------------
These look like they can share CHECK-V6V7?


================
Comment at: llvm/test/CodeGen/ARM/smml.ll:84
+; CHECK-THUMBV7EM-NEXT:    bx lr
 ; CHECK-V4-THUMBV7M-LABEL: Test0:
 ; CHECK-V4-THUMBV7M:       @ %bb.0: @ %entry
----------------
Is this left over?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104597/new/

https://reviews.llvm.org/D104597