[lld] ef75358 - [lld/mac] Delete incorrect FIXME

[Nico Weber via llvm-commits]

Author: Nico Weber
Date: 2021-06-23T16:25:34-04:00
New Revision: ef75358080a28501eccc552a3fa8214ceb3f34dc

URL: https://github.com/llvm/llvm-project/commit/ef75358080a28501eccc552a3fa8214ceb3f34dc
DIFF: https://github.com/llvm/llvm-project/commit/ef75358080a28501eccc552a3fa8214ceb3f34dc.diff

LOG: [lld/mac] Delete incorrect FIXME

"""Bitcode symbols only exist before LTO runs, and only serve the purpose of
resolving visibility so LTO can better optimize. Running LTO creates ObjFiles
from BitcodeFiles, and those ObjFiles contain regular Defined symbols (with
isec set and all) that will replace the bitcode symbols. So things should
(hopefully) work as-is :)"""

  -- https://reviews.llvm.org/rGdbbc8d8333f29cf4ad6f4793da1adf71bbfdac69#inline-6081

Added: 
    

Modified: 
    lld/MachO/UnwindInfoSection.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp
index e1e8d3093713..f82395b9d03e 100644
--- a/lld/MachO/UnwindInfoSection.cpp
+++ b/lld/MachO/UnwindInfoSection.cpp
@@ -297,8 +297,6 @@ static void addEntriesForFunctionsWithoutUnwindInfo(
   // Add explicit "has no unwind info" entries for all global and local symbols
   // without unwind info.
   auto markNoUnwindInfo = [&cuVector, &hasUnwindInfo](const Defined *d) {
-    // FIXME: The d->isec null check might be incorrect for symbols
-    // from LTO files.
     if (d->isLive() && d->isec && isCodeSection(d->isec)) {
       Ptr ptr = d->getVA();
       if (!hasUnwindInfo.count(ptr))