[PATCH] D104801: [MemCpyOpt] Enable memcpy optimization for NVPTX back-end.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D104801#2836898 <https://reviews.llvm.org/D104801#2836898>, @tra wrote:

> This change only enables the pass for NVPTX where use of memcpy/memset intrinsics is fine and it does not change anything for other back-ends.
>
> Figuring out a better criteria for enabling/disabling the pass can be dealt with separately by someone with better understanding of the pass than myself.

I think these questions are rather related. Why does NVPTX require special handling here? If these libcalls are actually available, then you need to enable them in TLI. If they aren't, but the intrinsics form is still usable, then the libcall checks in MemCpyOpt are wrong and we should adjust those. A separate TTI hook seems like the wrong solution in either case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104801/new/

https://reviews.llvm.org/D104801