[PATCH] D104798: [WPD] Don't optimize calls more than once

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 11:56:53 PDT 2021


aeubanks added a comment.

This probably requires more test coverage, but I'm not super familiar

In D104798#2836614 <https://reviews.llvm.org/D104798#2836614>, @tejohnson wrote:

>> WPD currently assumes that each vtable load corresponds to one virtual call. However, with -fstrict-vtable-pointers this may not be true.
>
> In the test case there is still a one to one correlation between the vtable load and virtual call. Do you mean that it can correspond to more than one type test assume sequence?

Originally there are two vtable loads, each with a type test assume sequence. The vtable loads become coalesced, leaving two type test assume sequences for one vtable load.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104798/new/

https://reviews.llvm.org/D104798



More information about the llvm-commits mailing list