[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 11:10:00 PDT 2021


aaron.ballman added inline comments.


================
Comment at: clang/test/AST/arithmetic-fence-builtin.c:34
+
+  v = (a + b);
+
----------------
aaron.ballman wrote:
> Does the `(a + b)` still have an AST node for the `ParenExpr`?
Nevermind, it won't, it'll have the `CallExpr` node.

I think this may be somewhat surprising to folks who use AST matchers or `-ast-print`, but I'm not certain that there's a better way to implement this that would keep the `ParenExpr` in the AST for full source fidelity, so I think this is reasonable enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100118/new/

https://reviews.llvm.org/D100118



More information about the llvm-commits mailing list