[PATCH] D103292: [lld-macho] Implement ICF

[Greg McGary via Phabricator via llvm-commits]

gkm marked an inline comment as done.
gkm added inline comments.


================
Comment at: lld/MachO/ICF.cpp:109
+          return false;
+        if (da->isAbsolute() != da->isAbsolute())
+          return false;
----------------
int3 wrote:
> I guess we do need those extra tests :)
Yow! I am having trouble writing assembler to define absolute & relocatable symbols with the same value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103292/new/

https://reviews.llvm.org/D103292