[PATCH] D104641: [LICM] Strip context sensitive attributes after call hoisting

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 07:52:31 PDT 2021


jdoerfert added inline comments.


================
Comment at: llvm/lib/IR/Instructions.cpp:350
+	
+	// Whitelist attributes we should strip.
+  static constexpr Attribute::AttrKind ParamAttrsToStrip[] = {
----------------
We got rid of "whitelist". It is also weird to call it that as we actually remove those. I'm not sure having a list here is great. Should we have a `Attribute::isABIrelated()` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104641/new/

https://reviews.llvm.org/D104641



More information about the llvm-commits mailing list