[PATCH] D104431: [lld] Add lto-cspgo-warn-mismatch option for COFF

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 07:51:32 PDT 2021


tejohnson added a comment.

In D104431#2835530 <https://reviews.llvm.org/D104431#2835530>, @YolandaCY wrote:

> Thanks Teresa for the comments.
>
> For the first question, clang uses the -Wno-backend-plugin option to ignore the warnings.
> This is mentioned in the How to build clang and LLVM with PGO <https://llvm.org/docs/HowToBuildWithPGO.html> user guide.
>
> I haven't figured out how this correlates to the internal -no-pgo-warn-mismatch option though. Any tips?

I traced it through and it looks like it will disable any warning coming from outside of clang (so LLVM) that doesn't have another type of handling in this switch statement:
http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CodeGenAction.cpp#818

So it looks like a larger hammer because it could affect other warning types too.

@xur @davidxl do either of you know why we don't support something more fine grained in clang such as gcc's -Wno-coverage-mismatch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104431/new/

https://reviews.llvm.org/D104431



More information about the llvm-commits mailing list