[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

[Maryam via Phabricator via llvm-commits]

MaryamBen marked 2 inline comments as done.
MaryamBen added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp:61
     report_fatal_error("Unimplemented fixup kind.");
+  case PPC::fixup_ppc_half16ds:
   case PPC::fixup_ppc_half16: {
----------------
jhenderson wrote:
> I'm not a PPC/XCOFF/AIX person, so I might be talking nonsense, but it seems like this part of the patch (i.e. the file) isn't really about 64-bit relocation support in XCOFF files?
This part allow us to get the value of SignAndSize field. 
fixup_ppc_half16ds is used in 64-bit and fixup_ppc_half16 in 32-bit.

```
struct XCOFFRelocation {
  uint32_t SymbolTableIndex;
  uint64_t FixupOffsetInCsect;
  uint8_t **SignAndSize**;
  uint8_t Type;
};
```


================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:347
+; CHECKSYM64-NEXT:   Symbol {
+; CHECKSYM64-NEXT:     Index: [[#Index:]]
+; CHECKSYM64-NEXT:     Name: .foo_ext_weak
----------------
jhenderson wrote:
> If I'm not mistaken, you should capture the .file symbol index, rather than this one and work from there.
The source filename part isn't implemented yet even for 32-bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644