[PATCH] D104771: [AArch64] Add CodeGen tests for vector reduction intrinsics. NFC

Wed Jun 23 05:59:47 PDT 2021

fhahn added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/reduce-and.ll:5
+define i1 @test_redor_v1i1(<1 x i1> %a) {
+; CHECK-LABEL: test_redor_v1i1:
+; CHECK:       // %bb.0:
----------------
RosieSumpter wrote:
> fhahn wrote:
> > For boolean reductions, there's already `llvm/test/CodeGen/AArch64/vecreduce-bool.ll`. Can those tests be unified to reduce duplication?
> It seems that vecreduce-bool.ll is testing something slightly different as it is looking at the pattern of a compare with a reduction, so generates e.g. uminv and umaxv instructions. I have agreed with @SjoerdMeijer to keep these tests separate for now.
ok fair enough.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104771/new/

https://reviews.llvm.org/D104771