[PATCH] D104271: llvm-dwarfdump: Print warnings on invalid DWARF

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 05:28:27 PDT 2021


jhenderson added a comment.

Just some clang-tidy warnings.



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h:377
+    return llvm::any_of(getSupportedAddressSizes(),
+                        [=](auto elem) { return elem == AddressSize; });
   }
----------------



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:319
+  if (!DWARFContext::isAddressSizeSupported(getAddressByteSize())) {
+    SmallVector<std::string, 3> sizes;
+    for (auto size : DWARFContext::getSupportedAddressSizes())
----------------
Nit: fix clang-tidy warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104271/new/

https://reviews.llvm.org/D104271



More information about the llvm-commits mailing list